Skip to content

Conversation

@ajhelsby
Copy link
Contributor

@ajhelsby ajhelsby commented Nov 2, 2022

This PR

Adds all the features required to reach compliance with spec 0.3.0

  • Remove context transformation
  • Verify context merging order for before hooks

Related Issues

Fixes #8

Notes

Follow-up Tasks

How to test

Signed-off-by: Andrew Helsby <[email protected]>

Signed-off-by: Andrew Helsby <[email protected]>
Signed-off-by: Andrew Helsby <[email protected]>

Signed-off-by: Andrew Helsby <[email protected]>
…the client

Signed-off-by: Andrew Helsby <[email protected]>

Signed-off-by: Andrew Helsby <[email protected]>
# Conflicts:
#	open_feature/open_feature_client.py
Signed-off-by: Andrew Helsby <[email protected]>

Signed-off-by: Andrew Helsby <[email protected]>
Signed-off-by: Andrew Helsby <[email protected]>

Signed-off-by: Andrew Helsby <[email protected]>
Signed-off-by: Andrew Helsby <[email protected]>

Signed-off-by: Andrew Helsby <[email protected]>
Signed-off-by: Andrew Helsby <[email protected]>

Signed-off-by: Andrew Helsby <[email protected]>
@matthewelwell
Copy link
Member

The commits specific to 0.3.0 seem fine, but I've left a few comments on the PR for the 0.2.0 updates which can be seen in this PR.

Can we cherry pick the 0.3.0 commit onto a clean branch or does it rely on previous commits?

@ajhelsby

@toddbaert toddbaert self-requested a review November 9, 2022 20:15
Comment on lines +261 to +265
merged_hooks = (
self.provider.get_provider_hooks()
+ flag_evaluation_options.hooks
+ self.hooks
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will eventually want to implement the API-level hooks.

@toddbaert toddbaert mentioned this pull request Nov 9, 2022
@ajhelsby ajhelsby closed this Nov 11, 2022
@ajhelsby ajhelsby deleted the feature/spec-0.3.0 branch November 11, 2022 10:25
kikihakiem pushed a commit to ResalApps/openfeature-python-sdk that referenced this pull request Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update SDK to be compliant with spec v0.3.0

4 participants